Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix table indenting #3725

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix table indenting #3725

merged 1 commit into from
Dec 3, 2024

Conversation

dgrove-oss
Copy link
Contributor

What type of PR is this?

/cleanup

What this PR does / why we need it:

Fixes table indenting caused by GitHub merge of review comment on previous PR

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit ef6b0ef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/674f1d294034860008c485dd
😎 Deploy Preview https://deploy-preview-3725--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mimowo
mimowo reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c5027752dff2936078be9b2d999b2d8635ba9ed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrove-oss, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@mimowo
Copy link
Contributor

mimowo commented Dec 3, 2024

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 298fb37 into kubernetes-sigs:main Dec 3, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Dec 3, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #3725 failed to apply on top of branch "website":

Applying: fix table indenting
Using index info to reconstruct a base tree...
M	site/content/en/docs/installation/_index.md
Falling back to patching base and 3-way merge...
Auto-merging site/content/en/docs/installation/_index.md
CONFLICT (content): Merge conflict in site/content/en/docs/installation/_index.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix table indenting

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor

mimowo commented Dec 3, 2024

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #3725 failed to apply on top of branch "website":

Applying: fix table indenting
Using index info to reconstruct a base tree...
M	site/content/en/docs/installation/_index.md
Falling back to patching base and 3-way merge...
Auto-merging site/content/en/docs/installation/_index.md
CONFLICT (content): Merge conflict in site/content/en/docs/installation/_index.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix table indenting

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgrove-oss dgrove-oss deleted the fix-indent branch December 13, 2024 16:57
@tenzen-y tenzen-y mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@dgrove-oss @k8s-ci-robot @mimowo @k8s-infra-cherrypick-robot